Modern Refactor of lib #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great pull request, thanks at @jeichorn. We're releasing v2 of the GAuthify API (which very slightly breaks backwards compatibility) in a week or so so I'll adapt this for that version. The upgrade path on your end should be pretty straight forward and the first version of the API is not being deprecated any time soon. |
|
Any possibility of this going in? Looks like v2 never happened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a real pull request, since it would break all backwards compatibility with your current users, so couldn't be merged in this form.
If you are interested in headed in this direction for your official release let me know, otherwise I will maintain this fork since we needed a version of the lib that meets our coding standards.